[wasm-metadata] parse OCI author custom section #1925
Draft
+101
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing the
authorcustom section, implementing parts of #1922. Thanks!Draft Notes
I'm filing this PR early and as a draft because I'm not 100% sure I'm following best practices here. It's my first time using
wasmparserandwasm-encoder, and I'm for example not sure whetherparse_wasmshould take aBinaryReaderorCustomSectionReader.Also: I was looking for something like a
Parsetrait, but I don't thinkwasmparserhas one? I quite liked the encoder side of things.Finally: in this PR I'm basically just wrapping
CustomSectionin a newtype - however that means storing the internal data as a byte array rather than a string. How do we feel about that?I'm asking these questions since I'm planning to repeat this pattern a number of times for the other custom sections, and it seems worth making sure it's early on. Thanks!