[C] Prefex function export names with exports_.
#1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the C bindings, prefix exported function names with `exports_` so
that a world that imports and exports the same function can do so
without collisions.
For example, with this WIT:
```wit
package green:blue;
world my-world {
import purple: func();
export purple: func();
}
```wit
This fixes a wit-bindgen panic with:
```
duplicate symbols: "name `my_world_purple` already defined"
```
alexcrichton
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the C bindings, prefix exported function names with
exports_so that a world that imports and exports the same function can do so without collisions.For example, with this WIT:
duplicate symbols: "name
my_world_purplealready defined"