Removed configure_vivado_synth_tool from project

[yonnorc42]

Fixes #314

[reillymck]

This is looking pretty good! If you would just delete the configure_vivado_tool function from flow_utils then it should be good to go. (pending the unit tests passing).

[KeenanRileyFaulkner]

I think any issues with the dictionary instance, if they exist, will come up because of how our configure rule works. It has to blow away the ninja build file and remake it. Potential issues would be if we change a script file and run ninja again, and the issue would have to do with how the flow args are re-read into the build file as seen at the bottom of the ninja_flow_manager.py file

[yonnorc42]

It looks like one of the unit tests (so far) failed because of the .get("synth")

[jgoeders]

@yonnorc42 OK, looks like we will need a few more fixes to resolve this. In places like this, you will need to do something like:

if flow_args is None:
  flow_args = []

You may be tempted to change the default flow_args argument value to [], but this is a bad idea.

[yonnorc42]

@jgoeders I didn't see your comment before I did another request

[yonnorc42]

@yonnorc42 OK, looks like we will need a few more fixes to resolve this. In places like this, you will need to do something like:

if flow_args is None:
  flow_args = []

You may be tempted to change the default flow_args argument value to [], but this is a bad idea.

In this case, wouldn't I make it an empty dictionary instead of an empty list?

[jgoeders]

@yonnorc42

In this case, wouldn't I make it an empty dictionary instead of an empty list?

Yes, you're correct.

[yonnorc42]

@yonnorc42 OK, looks like we will need a few more fixes to resolve this. In places like this, you will need to do something like:

if flow_args is None:
  flow_args = []

You may be tempted to change the default flow_args argument value to [], but this is a bad idea.

When I implement that if statement into the required files, it passes the unittests now, but it fails the pylint tests, and I think it's saying I failed because I have duplicate lines of code in all those places. This makes me think it wants me to use a function instead of a duplicate if statement in all those files, but I feel like that's essentially what we had originally with configure_vivado_synth_tool

[yonnorc42]

I think this is ready to merge, unless you want me to change it