handle dsps #495
Merged
handle dsps #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to fix this, it's not working right now |
|
This is working now |
|
I'm not sure if we can do this since the property isn't showing up for one of the designs. For all we know fasm2bels is right about the property and vivado is hiding it. Let's hold off on putting this in main for now. But, let's keep using it for now so that these pins pass and we see if there are other things to work on or if this is the only thing holding us back from passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles DSPs by ignoring the pin if it meets the criteria of being the opposite const net of the original, and the IS_x_INVERTED property being true for that pin. Let me know what you think @reillymck If this solution isn't viable, then we need to adjust some fasm2bels code instead of our code, because this is the only solution using our code that I've thought of.