Dataset metrics #514
Merged
Dataset metrics #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs dependencies on the scripts in the ninja build statements, still, so that rebuild triggers when utils update |
jgoeders
approved these changes
Nov 29, 2024
| """Get the name of the build directory for this flow""" | ||
| return "dataset_metrics" | ||
|
|
||
| def add_ninja_deps(self, deps): |
There was a problem hiding this comment.
I don't think this is required if it's just calling super. The behavior will be the same if you remove it.
|
|
||
| def sort_metrics(metrics): | ||
| """Sort the values for each metric in the dictionary.""" | ||
| for ip, _ in metrics.items(): |
There was a problem hiding this comment.
If you want to loop through keys, just use:
for ip in metrics:
|
@KeenanRileyFaulkner It looks like this is failing CI. Anything I can help with? |
|
Sorry. I didn't realize there was a formatting issue. I'm out of town I'm right now, but will try to fix it when I have a chance this weekend. |
|
@jgoeders All tests are passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two scripts to bfasst, allowing for efficient computation of metrics on randsoc-based graphs for gnn training datasets. The metrics can be computed ad-hoc through the use of command line options. Bfasst is used to iterate through a dataset, run process_graph.py on each graph in it, then run accumulate_metrics.py at the end.
If things run for too long, and you don't want to wait for all instances of process_graph.py to finish, kill the run and invoke the accumulation script on the output directory directly.
The final output is contained in a file called
summary_stats.log, with individual metrics for each instance of each ip contained inmaster_metrics.log. accumulate_metrics.py will overwrite these files every time, but options are available to specify a different output name, if the utility is used directly.