Skip to content

Commit

Permalink
updated msg create and update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@faneaatiku
faneaatiku committed Mar 16, 2024
1 parent cc533ea commit 8efa365
Show file tree
Hide file tree
Showing 4 changed files with 296 additions and 123 deletions.
55 changes: 34 additions & 21 deletions x/rewards/keeper/msg_server_staking_reward_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,21 @@ import (
"github.com/bze-alphateam/bze/testutil/simapp"
"github.com/bze-alphateam/bze/x/rewards/types"
sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
)

func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidRequest() {
goCtx := sdk.WrapSDKContext(suite.ctx)

_, err := suite.msgServer.CreateStakingReward(goCtx, nil)
suite.Require().NotNil(err)
suite.Require().ErrorIs(err, sdkerrors.ErrInvalidRequest)
}

func (suite *IntegrationTestSuite) TestUpdateStakingReward_InvalidRequest() {
goCtx := sdk.WrapSDKContext(suite.ctx)

_, err := suite.msgServer.UpdateStakingReward(goCtx, nil)
suite.Require().NotNil(err)
suite.Require().ErrorIs(err, sdkerrors.ErrInvalidRequest)
}

func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidCreator() {
Expand All @@ -41,43 +42,47 @@ func (suite *IntegrationTestSuite) TestUpdateStakingReward_InvalidCreator() {
func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward() {
goCtx := sdk.WrapSDKContext(suite.ctx)

addr1 := sdk.AccAddress("addr1_______________")
acc1 := suite.app.AccountKeeper.NewAccountWithAddress(suite.ctx, addr1)
suite.app.AccountKeeper.SetAccount(suite.ctx, acc1)

tests := []struct {
name string
msg types.MsgCreateStakingReward
}{
{
name: "empty prize amount",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "",
},
},
{
name: "zero prize amount",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "0",
},
},
{
name: "negative prize amount",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "-10",
},
},
{
name: "empty prize denom",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "",
},
},
{
name: "empty staking denom",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "",
Expand All @@ -86,7 +91,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "invalid min stake",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -96,7 +101,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "negative min stake",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -106,7 +111,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "invalid duration",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -117,7 +122,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "duration too low",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -128,7 +133,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "duration too high",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -139,7 +144,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "invalid lock",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -151,7 +156,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "negative lock",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -163,7 +168,7 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
{
name: "lock too high",
msg: types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand All @@ -182,6 +187,10 @@ func (suite *IntegrationTestSuite) TestCreateStakingReward_InvalidStakingReward(
func (suite *IntegrationTestSuite) TestUpdateStakingReward_InvalidStakingReward() {
goCtx := sdk.WrapSDKContext(suite.ctx)

addr1 := sdk.AccAddress("addr1_______________")
acc1 := suite.app.AccountKeeper.NewAccountWithAddress(suite.ctx, addr1)
suite.app.AccountKeeper.SetAccount(suite.ctx, acc1)

tests := []struct {
name string
msg types.MsgUpdateStakingReward
Expand All @@ -190,36 +199,36 @@ func (suite *IntegrationTestSuite) TestUpdateStakingReward_InvalidStakingReward(
{
name: "invalid duration",
msg: types.MsgUpdateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
Duration: "",
},
},
{
name: "zero duration",
msg: types.MsgUpdateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
Duration: "0",
},
},
{
name: "negative duration",
msg: types.MsgUpdateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
Duration: "-220",
},
},
{
name: "missing staking reward",
msg: types.MsgUpdateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
Duration: "10",
RewardId: "notastakingrewardid",
},
},
{
name: "not enough balance",
msg: types.MsgUpdateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
Duration: "10",
RewardId: "001",
},
Expand All @@ -237,8 +246,12 @@ func (suite *IntegrationTestSuite) TestUpdateStakingReward_InvalidStakingReward(

func (suite *IntegrationTestSuite) TestCreateStakingReward_MissingSupply() {
goCtx := sdk.WrapSDKContext(suite.ctx)
addr1 := sdk.AccAddress("addr1_______________")
acc1 := suite.app.AccountKeeper.NewAccountWithAddress(suite.ctx, addr1)
suite.app.AccountKeeper.SetAccount(suite.ctx, acc1)

msg := types.MsgCreateStakingReward{
Creator: someRandomAddress,
Creator: addr1.String(),
PrizeAmount: "10",
PrizeDenom: "ubze",
StakingDenom: "ubze",
Expand Down
2 changes: 1 addition & 1 deletion x/rewards/keeper/msg_server_trading_reward.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (k msgServer) CreateTradingReward(goCtx context.Context, msg *types.MsgCrea
tradingReward,
)

return &types.MsgCreateTradingRewardResponse{}, nil
return &types.MsgCreateTradingRewardResponse{RewardId: tradingReward.RewardId}, nil
}

func (k msgServer) checkUserBalances(ctx sdk.Context, neededCoins sdk.Coins, address sdk.AccAddress) error {
Expand Down
Loading

0 comments on commit 8efa365

Please sign in to comment.