Skip to content

Commit

Permalink
fix for getaddresses RPC call watch-only addresses inclusion
Browse files Browse the repository at this point in the history
  • Loading branch information
miodragpop committed Jul 10, 2019
1 parent d04b8e9 commit 3626872
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/wallet/wallet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3994,8 +3994,15 @@ set<CTxDestination> CWallet::GetAddresses(bool include_watch_only)
CTxDestination address;
if(!IsMine(txin)) /* If this input isn't mine, ignore it */
continue;

if(!ExtractDestination(mapWallet[txin.prevout.hash].vout[txin.prevout.n].scriptPubKey, address))
continue;

bool is_watch_only = (pwalletMain ? ::IsMine(*pwalletMain, address) : ISMINE_NO) & ISMINE_WATCH_ONLY;

if (!include_watch_only && is_watch_only)
continue;

t_addresses.insert(address);
any_mine = true;
}
Expand All @@ -4010,6 +4017,12 @@ set<CTxDestination> CWallet::GetAddresses(bool include_watch_only)
CTxDestination txoutAddr;
if(!ExtractDestination(txout.scriptPubKey, txoutAddr))
continue;

bool is_watch_only = (pwalletMain ? ::IsMine(*pwalletMain, txoutAddr) : ISMINE_NO) & ISMINE_WATCH_ONLY;

if (!include_watch_only && is_watch_only)
continue;

t_addresses.insert(txoutAddr);
}

Expand Down

0 comments on commit 3626872

Please sign in to comment.