-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #49 error of caused by Windows GCC compiler #50
Conversation
Warnings with CRAN checks caused by depreciated R APIs. Being tracked in extendr/extendr#806. |
Build errors due to non-api calls. Fixed in the master branch of extendr/rextendr. Will update this PR with the latest version of rextendr when it is released. |
The non-api issues are dealt with in #51 |
73d78b5
to
ef26b78
Compare
I'm very curious as to what is going on here.. Can you explain it to me? |
This PR aims to address the linker issue in #49. The exact issue is hard to replicate, as it passes checks in my GitHub action, and passes both R-release and R-devel on the win-builder service (https://win-builder.r-project.org/). There has been progress in this PR, as the current master branch will fail to build on win-builder. After I updated I think the last piece of the puzzle is If you have any suggestions for how to fix this error, I would welcome any comments. |
Yes! We routinely update the package configuration in remotes::install_github("extendr/rextendr")
usethis::create_package("exampleRustRpkg")
rextendr::use_extendr() And have a look at those files, copy them over, and adjust them to meet your package's needs. Sorry, but these things are constantly changing, and we couldn't get it right the first time. |
The reason I'm also here, is because I think you'd have some issues here with extracting info from the shell in Makevars. Something about using backticks for this for compatibility.. I don't recall the details of this, unfortunately. See https://cran.r-project.org/doc/manuals/R-exts.html#Writing-portable-packages-1 |
This branch has solved some other peoples issues with windows, so I will merge this PR. I will work on a fix in a separate branch. |
Fixes error caused by gcc compiler provided by Rtools. Tested on R's provided windows check service.