Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes file descriptor leak as described in #253
Reproduced by modifying
_example/simple-echo/main.go
, looping the body of the main function in order to observe multiple calls toprompt.Input()
. "Exit" added for convenience:Each call to Input will leak another file descriptor, seen with
lsof -p <GO PID> | grep 'dev\/tty' | wc -l
:Here you can see the count of /dev/tty file descriptors increasing:
Calling
syscall.Close(t.fd)
prevents this leak. After this fix the count of file descriptors is constant: