Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second episode of nicking the
goodnon-shrink-log parts from #172, #174, and #176.Highlights:
dune
's expect test support and simplify thedune
filescheck_exn
I see this last item as supplementing the
tup
tests from @vch9. I want to collect our tuple tests, but in order to keep the noise down I suggest we do so in a separate PR.The PR is probably best read one commit after another. None of this should be controversial though.
Objections or a quick glance and thumbs-up would be appreciated, as I would like to get the last tests in play before they bit rot further...