Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit and expect tests #234

Merged
merged 8 commits into from
Apr 10, 2022
Merged

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Apr 2, 2022

This is the second episode of nicking the good non-shrink-log parts from #172, #174, and #176.

Highlights:

  • by renaming expect-files we can utilize dune's expect test support and simplify the dune files
  • tests of check_exn
  • unit-tests for QCheck, corresponding to those from QCheck2
  • a tree shrinker test for QCheck, corresponding to the one from QCheck2
  • a bunch of tuple and bind-tests, both positive, negative, and with statistics

I see this last item as supplementing the tup tests from @vch9. I want to collect our tuple tests, but in order to keep the noise down I suggest we do so in a separate PR.

The PR is probably best read one commit after another. None of this should be controversial though.
Objections or a quick glance and thumbs-up would be appreciated, as I would like to get the last tests in play before they bit rot further...

@jmid
Copy link
Collaborator Author

jmid commented Apr 8, 2022

I'll merge these tests shortly unless I hear an outcry of objections... 😀

@jmid jmid merged commit 0eb5948 into c-cube:master Apr 10, 2022
@jmid jmid mentioned this pull request Apr 16, 2022
@jmid jmid deleted the add-unit-and-expect-tests branch April 19, 2022 10:25
@jmid jmid mentioned this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant