-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote and escape in QCheck.Print.{char,string}, aligning it with QCheck2.Print #297
Conversation
To assess if this change would break anything I've rolled an opam-repo PR ocaml/opam-repository#27038 Based on this experiment I therefore favor this one over #296. OK with you @c-cube? |
1f67a37
to
3639d68
Compare
Rebased on |
Looking again at our workaround in multicoretests I was reminded that The latest commits thus fix The expect test updates in d8f3b5f and f773f75 document why this helps the end-user output. |
0640326
to
75f1061
Compare
Rebased on main after merging #302 |
OK. Since no objections have surfaces I'll go ahead and merge this one. |
As mentioned in #296
QCheck.Observable.{char,string}
function printers yield unhelpful output, despite usingQCheck.Print.{char,string}
QCheck.Observable.{char,string}
QCheck2.Print.{char,string}
already quotes and escapes, creating aQCheck.Print
/QCheck2.Print
mismatch for chars and stringsThis PR thus suggests the breaking change of fixing
QCheck.Print.{char,string}
.This further opens up for cleaning up some of the ad-hoc printers in the
arbitrary
combinators (commit d1c1fee)I'm hoping for fellow QCheck users and developers to chip in to the discussion and share which PR and
QCheck2.Print.{char,string}
they prefer... 🙏 🙂