Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split image & add example #26

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

QuanticPotatoes
Copy link

@QuanticPotatoes QuanticPotatoes commented Mar 15, 2018

I propose to add the possibility to add an single image in a <a-sky> element.

Like this

And split it with the property split

<!-- Paths to left and right images -->
      <a-assets>
        <img id="both" src="textures/LR.jpg">
      </a-assets>

      <!-- Camera -->
      <a-entity camera look-controls position="0 0 0" stereocam="eye:left"></a-entity>

      <!-- Sky sphere -->
      <a-sky id="sky1" src="#both" stereo="eye:left;split:vertical"></a-sky>
      <a-sky id="sky2" src="#both" stereo="eye:right;split:vertical"></a-sky>

Have a nice day 😃 !

@QuanticPotatoes
Copy link
Author

sorry, i have commit also the build files, my mistake

@vincentfretin
Copy link
Member

I did a similar change to support Top/Bottom images 5 years ago, so about the same time.
I just did an alternative change in my current project, see #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants