Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected profile_index to 1 indexed #49

Closed
wants to merge 2 commits into from
Closed

corrected profile_index to 1 indexed #49

wants to merge 2 commits into from

Conversation

callumrollo
Copy link
Collaborator

Fixes Issue #40

I noticed this as processing datasets in chunks of N dives would always produce N-1 profiles. profile_index is given a value of 0 when inflecting (see discussion in #40) but the first profile is given a value of 0. Later when profiles and grids are extracted form the timeseries, this first valid dive is treated as an inflection point and ignored.

This PR:

  • starts dives from 1 rather than 0 (heresy for Python I know, but necessary in this case)
  • corrects the comment of profile_index to correctly note that samples during inflection have profile index 0, not N + 0.5
  • removed the function get_profiles which is not used anywhere in the codebase

This should fail the tests for profile_index in slocum and seaexplorer

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant