corrected profile_index to 1 indexed #49
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #40
I noticed this as processing datasets in chunks of N dives would always produce N-1 profiles. profile_index is given a value of 0 when inflecting (see discussion in #40) but the first profile is given a value of 0. Later when profiles and grids are extracted form the timeseries, this first valid dive is treated as an inflection point and ignored.
This PR:
get_profiles
which is not used anywhere in the codebaseThis should fail the tests for profile_index in slocum and seaexplorer