Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #3697 add waypoints external resources section #3846

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

florentcadot
Copy link
Contributor

#3697

Associated backend PR: c2corg/v6_api#1747

How to test:

Pull the associated backend branch feature/add-waypoints-external-resources
Run the added migration using docker-compose exec api .build/venv/bin/alembic upgrade head

Create a new waypoint and fill the external_resources field. Then update the external resources of this.

You should see something like this:

Screenshot from 2024-02-18 11-03-40

image

Copy link
Member

@brunobesson brunobesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me thanks. I haven't tested it though because I couldn't manage to launch the API side on my laptop (work restrictions + I am not fluent with python).

IMHO, we can merge both parts (backend and frontend).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants