-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Add unit tests for libc #1974
base: master
Are you sure you want to change the base?
Conversation
…alignments (style) in libc bindings
…after sort, and let everyone fail to compare results
Is this still a draft? |
Yes, I'm not ready yet with most functions. I'm a bit busy at the moment, but would like to get this out of draft status within at most 2 weeks, preferably 1 week. |
This reverts commit 58c54a8.
Update: I've been working on this when I have time, and the original timeline is a bit unrealistic. For most functions I have to check if they are correct and if they are ISO C or just POSIX (and thus need |
This PR aims to add unit tests for libc.
Along the way, I also discovered some issues with the bindings currently present. Some pointers being misaligned (
void *
instead ofvoid*
), but also a wrong return type forlibc::bsearch()
.This is a draft PR, because I'm far from done, but would like some input on how thorough these tests should be. I feel like they shouldn't be that thorough, because they should be battle-tested C-code, we're just testing that we can call them from C3, and potentially providing an example for people.