Skip to content

Commit

Permalink
disassembler
Browse files Browse the repository at this point in the history
  • Loading branch information
c3rb3ru5d3d53c committed May 23, 2022
1 parent 64b0d8e commit 1a43ffc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/disassembler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@ void Disassembler::LinearDisassemble(void* data, size_t data_size, size_t offset
//
// * Weaknesses *
// - We don’t collect calls (these are assumed to be collected in the recursive disassembler) (DONE)
// - We don’t reset the state on ret or call instructions possibly missing some valid blocks
// - We don’t collect the next address after a jmp (next block) missing some valid blocks (DONE)
// - We don’t reset the state on ret or call instructions possibly missing some valid blocks (DONE)
// - We don’t collect the next address after a jmp (next block) missing some valid blocks (effective?)
// - Even with the filtering we will still add some number of addresses that are from invalid jmp institutions

csh cs_dis;
Expand Down

0 comments on commit 1a43ffc

Please sign in to comment.