Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official jsr deploy pr #690

Closed
wants to merge 11 commits into from

Conversation

bjesuiter
Copy link

Hi @c4spar !

Since deno's new registry jsr launched, it's a little complicated to use cliffy with it, since you cannot publish code to jsr which uses http imports.

Therefore I made the minimum necessary changes to be able to publish this lib to jsr.
Since I simply swapped out the imports with jsr std imports, it should still be possible to publish this on deno.land/x as is.

Here is the example of the working publish (under one of my scopes - codemonument):
https://jsr.io/@codemonument/cliffy/versions

It would be nice if you could accept this!

[!INFO]
Please review the scope name for this package. I chose @cliffy-io as the scope for now, because we may be able to publish more things under there, like more custom types, etc.
But you can also choose your own c4spar name as the scope.
jsr only requires any scope.

@bjesuiter
Copy link
Author

If you like this, I can also add a pr later for auto-publishing this from a tag via github actions.

You can look at one example by me here:
https://github.com/codemonument/deno_update_denoconfig/blob/main/.github/workflows/publish.yml

@andrewthauer
Copy link
Contributor

andrewthauer commented Apr 1, 2024

Duplicate of #679?

@c4spar
Copy link
Owner

c4spar commented Apr 5, 2024

Thx @bjesuiter for your PR and your time but we already have a PR for jsr. So closing as duplicate.

@c4spar c4spar closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants