Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add built-in jsr upgrade provider (rework) #692

Merged
merged 64 commits into from
May 13, 2024

Conversation

JOTSR
Copy link
Contributor

@JOTSR JOTSR commented Apr 7, 2024

Summary

Add buit-in support of jsr as upgrade provider.
Rework of #687 from main branch (deleting all changes from #679).

Motivation

Allow to seamlessly upgrade jsr hosted cli.

Changes

JOTSR and others added 30 commits February 29, 2024 11:55
Remove `examples` directory from workspace to disable `deno publish` for it.
@c4spar c4spar force-pushed the feat/jsr_provider_rework branch from 00f78c2 to 2a584fb Compare May 5, 2024 13:35
@JOTSR JOTSR requested a review from c4spar May 6, 2024 08:52
@JOTSR
Copy link
Contributor Author

JOTSR commented May 6, 2024

@c4spar what your though for provider config defaults ?

@c4spar
Copy link
Owner

c4spar commented May 8, 2024

I think we can remove the default value for the main option for now. I am currently working on a refactoring of the upgrade command and may move the default value to the provider itself.

JOTSR added 4 commits May 10, 2024 21:56
In order to simplify usage of the `upgrade` command especially for `jsr` support,
the default value for `main` option was removed.
See c4spar#692 (comment)
and c4spar#692 (comment) .

BREAKING CHANGE: @cliffy/command/upgrade
@JOTSR JOTSR force-pushed the feat/jsr_provider_rework branch from 107b89e to 3bd7376 Compare May 10, 2024 20:08
Copy link
Owner

@c4spar c4spar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx again @JOTSR! LGTM 👍

@c4spar c4spar marked this pull request as ready for review May 13, 2024 22:25
@c4spar c4spar merged commit b976d26 into c4spar:main May 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants