-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add built-in jsr
upgrade provider (rework)
#692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Benjamin Fischer <[email protected]>
Remove `examples` directory from workspace to disable `deno publish` for it.
c4spar
force-pushed
the
feat/jsr_provider_rework
branch
from
May 5, 2024 13:35
00f78c2
to
2a584fb
Compare
@c4spar what your though for provider config defaults ? |
I think we can remove the default value for the main option for now. I am currently working on a refactoring of the upgrade command and may move the default value to the provider itself. |
In order to simplify usage of the `upgrade` command especially for `jsr` support, the default value for `main` option was removed. See c4spar#692 (comment) and c4spar#692 (comment) . BREAKING CHANGE: @cliffy/command/upgrade
JOTSR
force-pushed
the
feat/jsr_provider_rework
branch
from
May 10, 2024 20:08
107b89e
to
3bd7376
Compare
c4spar
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx again @JOTSR! LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add buit-in support of jsr as upgrade provider.
Rework of #687 from main branch (deleting all changes from #679).
Motivation
Allow to seamlessly upgrade jsr hosted cli.
Changes
upgrade/provider/jsr.ts
.jsr
package (need discussion/improvement).