SV: Fix group refreshing issue on checkbox selection #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamabeshouse
approved these changes
Aug 16, 2021
alisman
reviewed
Aug 17, 2021
alisman
reviewed
Aug 17, 2021
| promises.push(comparisonClient.getGroup(groupId)); | ||
| } | ||
| const promises = missingGroupIds.map(groupId => | ||
| comparisonClient.getGroup(groupId) |
There was a problem hiding this comment.
comment getGroup will make a new group if it doesn't exist?
There was a problem hiding this comment.
It doesn't make new group, if gets group by id if it is present.
|
@kalletlak i'm curious why tracking newly created groups is important in fixing a bug that doesn't seem to involve new group creation (appears when selecting a group)? maybe put explaination in main comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#8616
Problem: same object (
_selectedComparisonGroups) is used for both creating and selecting groups. This is causing list to re-render whenever selection is made.Solution: use different object to track created groups and selected groups