Remove StudyID Requirement for Single Study in Custom Selection.

[deveshidwivedi]

Fix cBioPortal/cbioportal#10445

Changes:
Introduced a ternary operator to decide whether to include the studyId: prefix based on the isSingleStudy property. If it is a single study, only s.sampleId is used; otherwise, the original format with studyId: prefix is maintained.

[deveshidwivedi]

Hi @alisman, could you please review this?

[alisman]

@deveshidwivedi does the selection actually work without the study id prefix? in other words when you click the select button?

[deveshidwivedi]

I'm unable to open it in localhost since some time, please give me some time to check and make updates.

[alisman]

@deveshidwivedi give us another day and the issue with localhost will be resolved. we apologize. it has to do with a big release we are doing (6.0)

[alisman]

@deveshidwivedi can you do me a favor and rebase on master branch.

[deveshidwivedi]

hi @alisman, I'm still facing issues

[netlify]

✅ Deploy Preview for cbioportalfrontend ready!

Name	Link
🔨 Latest commit	8fc733f
🔍 Latest deploy log	https://app.netlify.com/sites/cbioportalfrontend/deploys/65a817b8315725000815bada
😎 Deploy Preview	https://deploy-preview-4822--cbioportalfrontend.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alisman]

should now be fixed. i'm checking this PR btw and will merge if things work

…

On Fri, Jan 12, 2024 at 3:31 AM Deveshi Dwivedi ***@***.***> wrote: hi @alisman <https://github.com/alisman>, I'm still facing issues — Reply to this email directly, view it on GitHub <#4822 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABNRGPUFXYVWHJKYN55NRDYODYGVAVCNFSM6AAAAABBOOWQCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBYGY2TANZVGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[alisman]

@deveshidwivedi @ino based on my testing, this ALREADY works in custom selection. It doesn't work in the custom data feature, but that isn't addressed by this PR:

[deveshidwivedi]

@alisman my bad, I'll update the code for custom data to resolve this issue. Also, the issue with local server still remains and it might be due to my machine, I am unable to see any updates for the changes I make. I'll close this pr for now and open one with an updated working code. Thanks!

[alisman]

Hi Davesh,
I'm happy to do a zoom with you and try to resolve the problem. It would actually be good to do so on behalf of other contributors.

[deveshidwivedi]

Thank you very much! Since i had a problem with the repo on my machine (which is windows), i tried forking it again and wasn't able to do it. Went through tutorials on the internet and finally got it on my device. I'll try to make updates again and get back here! This time it should work..