API client update about Mutation Assessor v4 data and UI changes #5015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
leexgh
changed the title
onursumer
approved these changes
Oct 3, 2024
packages/react-variant-view/src/component/functionalPrediction/FunctionalPrediction.tsx
Outdated
Show resolved
Hide resolved
packages/react-variant-view/src/component/functionalPrediction/MutationAssessor.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/annotation/genomeNexus/MutationAssessor.tsx
Outdated
Show resolved
Hide resolved
leexgh
force-pushed
the
fix-ma-v4
branch
2 times, most recently
from
53f0c90
to
6cdc6a3
Compare
|
failing e2e tests don't seem to be related, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: genome-nexus/genome-nexus#753
There are some API model changes about Mutation Assessor v4 in genome nexus. This pr changes data display and tooltip text to work with new data
Header tooltip:
Data and tooltip:
Test link (need to add Functional Impact in column dropdown): https://deploy-preview-5015.cancerrevue.org/results/mutations?cancer_study_list=msk_impact_2017&Z_SCORE_THRESHOLD=2.0&RPPA_SCORE_THRESHOLD=2.0&profileFilter=mutations%2Cstructural_variants%2Ccna&case_set_id=msk_impact_2017_cnaseq&gene_list=BRAF&geneset_list=%20&tab_index=tab_visualize&Action=Submit