Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample and patient counts toggle for cancer summary chart tooltip #5110

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gblaih
Copy link
Contributor

@gblaih gblaih commented Feb 20, 2025

Fix cBioPortal/cbioportal#11311

Adds option to toggle between sample and patient counts in tooltip of cancer summary chart in results view. Previously, it only showed sample counts with no option to switch.

Screenshot 2025-02-20 at 5 15 42 PM

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit f885742
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67be2fa8056e5f0008f47ad9
😎 Deploy Preview https://deploy-preview-5110.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gblaih ! The counts look good, but would be nice to update the "cases" text to "samples" when selecting "Sample Counts" (patient and case are often used as synonyms):

image

Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @gblaih ! Can you make the default "Patient Counts", similar to how the oncoprint works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cancer type summary shows sample counts in tooltip rather than cases
2 participants