Remove unnecessary checks for null

cBioPortal · Jun 26, 2024 · 0e0b086 · 0e0b086
1 parent 126c16a
commit 0e0b086
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/main/java/org/cbioportal/web/PublicVirtualStudiesController.java b/src/main/java/org/cbioportal/web/PublicVirtualStudiesController.java
@@ -92,8 +92,7 @@ public ResponseEntity<VirtualStudy> publishVirtualStudyData(
         @RequestParam(required = false) String typeOfCancerId,
         @RequestParam(required = false) String pmid
     ) {
-        if (requiredPublisherApiKey == null
-            || requiredPublisherApiKey.isBlank()
+        if (requiredPublisherApiKey.isBlank()
             || !requiredPublisherApiKey.equals(providedPublisherApiKey)) {
             return new ResponseEntity<>(null, HttpStatus.UNAUTHORIZED);
         }
@@ -129,8 +128,7 @@ public ResponseEntity<VirtualStudy> publishVirtualStudy(
         @RequestParam(required = false) String typeOfCancerId,
         @RequestParam(required = false) String pmid
     ) {
-        if (requiredPublisherApiKey == null
-            || requiredPublisherApiKey.isBlank()
+        if (requiredPublisherApiKey.isBlank()
             || !requiredPublisherApiKey.equals(providedPublisherApiKey)) {
             return new ResponseEntity<>(null, HttpStatus.UNAUTHORIZED);
         }
@@ -167,8 +165,7 @@ public ResponseEntity retractVirtualStudy(
         @PathVariable String id,
         @RequestHeader(value = "X-PUBLISHER-API-KEY") String providedPublisherApiKey
     ) {
-        if (requiredPublisherApiKey == null
-            || requiredPublisherApiKey.isBlank()
+        if (requiredPublisherApiKey.isBlank()
             || !requiredPublisherApiKey.equals(providedPublisherApiKey)) {
             return new ResponseEntity<>(null, HttpStatus.UNAUTHORIZED);
         }