Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set download button visibility in UI based on user role/group #10254

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Set download button visibility in UI based on user role/group #10254

merged 1 commit into from
Jul 19, 2023

Conversation

kalletlak
Copy link
Member

Fix #10248

RFC: https://docs.google.com/document/d/19KV2Yplzxl1wnUc5bJDeysGX8vmL24UNi41NlIkX44s/edit

Implements below logic

skin.hide_download_controls Download group in user role hide_download_controls to UI
TRUE Yes FALSE
TRUE No TRUE
FALSE Yes FALSE
FALSE No FALSE
data Yes FALSE
data No data

@inodb inodb requested review from haynescd and pvannierop and removed request for pvannierop and haynescd July 7, 2023 14:48
@inodb inodb requested a review from pvannierop July 12, 2023 15:35
inodb
inodb approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@JREastonMarks
Copy link
Contributor

Is there a test for getDownloadControl()?

@kalletlak
Copy link
Member Author

@JREastonMarks currently there are no test for this class (as it is static class). The way how the properties are loaded makes it hard to write tests for this class.

pvannierop
pvannierop requested changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution. I would also suggest that the Customizing-your-instance-of-cBioPortal.md file is included with some more detailed explanation of the feature.

core/src/main/java/org/mskcc/cbio/portal/util/GlobalProperties.java Outdated Show resolved Hide resolved
core/src/main/java/org/mskcc/cbio/portal/util/GlobalProperties.java Outdated Show resolved Hide resolved
core/src/main/java/org/mskcc/cbio/portal/util/GlobalProperties.java Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@inodb
Copy link
Member

inodb commented Jul 19, 2023

@kalletlak thanks! Re the testing, maybe good to file a follow up ticket if there isn't one already? It does seem like slightly complex logic. Agree that it would be a bigger project to enable testing for this class

@kalletlak kalletlak merged commit 8f6534e into cBioPortal:master Jul 19, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvannierop pvannierop pvannierop requested changes

@inodb inodb inodb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support download from UI based on user role/group
5 participants
@kalletlak @JREastonMarks @inodb @pvannierop @dippindots