Improve study-view treatment api's performance #10261
Conversation
kalletlak
changed the title
...mybatis/src/test/java/org/cbioportal/persistence/mybatis/TreatmentMyBatisRepositoryTest.java
Outdated
Show resolved
Hide resolved
...mybatis/src/test/java/org/cbioportal/persistence/mybatis/TreatmentMyBatisRepositoryTest.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/cbioportal/service/impl/TreatmentServiceImpl.java
Outdated
Show resolved
Hide resolved
| @@ -25,7 +25,7 @@ private Pair<List<String>, List<String>> filterIds(List<String> sampleIds, List< | |||
| } | |||
| Set<String> studiesWithTreatments = studyIds.stream() | |||
| .distinct() | |||
| .filter(studyId -> treatmentRepository.studyIdHasTreatments(studyId, key)) | |||
| .filter(studyId -> treatmentRepository.hasTreatmentData(Collections.singletonList(studyId), key)) | |||
There was a problem hiding this comment.
This might not be appropriate for this PR but do you think this could be done as a SQL query?
There was a problem hiding this comment.
We could. Also we might not need this once after moving to new database. I would prefer to leave it as is for now and revisit after moving to new database.
There was a problem hiding this comment.
Could you write a ticket for this. Even with a new database we may still need to address this issue.
There was a problem hiding this comment.
service/src/main/java/org/cbioportal/service/impl/TreatmentServiceImpl.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
I think we can ignore it. It is related to db data init. |
Improve performance for
/treatments/display-patient/treatments/display-sample/treatments/sample/treatments/patientImproves performance by 10x