New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabling SSL for MySQL connection #10276

Closed

pvannierop wants to merge 1 commit into cBioPortal:master from pvannierop:fix_no_ssl_for_python_scripts

Contributor

pvannierop commented Jul 14, 2023

Problem

When migrating the database the migration.py script tries to connect to the MySQL database over SSL, despite the db.use_ssl property having value false.

Analysis

The current and broken logic in migration.py to configure SSL is:

connection_kwargs = {here
if portal_properties.database_use_ssl == 'true':
    connection_kwargs['ssl'] = {"ssl_mode": True}

When I change this to the following, the db.use_ssl property is respected:

connection_kwargs = {}
if portal_properties.database_use_ssl == 'true':
    connection_kwargs["ssl_mode"] = "REQUIRED"
else:
   connection_kwargs["ssl_mode"] = "DISABLED"

Changes in this PR

This PR will add the ssl_mode to the kwargs of the migration script.


          Fix disabling SSL for MySQL connection

ea5252d

pvannierop self-assigned this

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

dippindots approved these changes

View reviewed changes

Member

dippindots left a comment

@pvannierop This fix looks good to me, maybe we can merge it along with the #10037

dippindots added the bug label

dippindots mentioned this pull request

Fix disabling SSL for MySQL connection #10353

Merged

Member

dippindots commented Sep 6, 2023

Closing this and created #10353

dippindots closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug