Filter out unauthorized studies when fetching study tags #10277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing this as I believe we decided to not expose study tags for unauthorized studies due to risk of exposing sensitive data, but feel free to re-open if I'm misremembering the discussion. One alternative implementation would be to allow exposing study tags endpoint by allowing deployers to opt in to sharing the tags or indicating clearly in the docs on this and the portal configuration file with some warnings that it exposes the tags for a study as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters out unauthorized studies by adding the
@PreFilterannotation to the/studies/tags/fetchendpoint.Depends on fixing authorization in
/studies(see #10267).At the moment a user with unauthorized studies gets an error screen on the index page. This is because the tags of all studies are fetched. However, you cannot fetch the study tags of unauthorized studies, resulting in a 403 and an error screen (see #10221) .
By filtering the studies in the backend, the frontend does not need to have any knowledge of authorized studies (see also cBioPortal/cbioportal-frontend#4653).