Generic assay binary types #10335
Merged
Generic assay binary types #10335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
reviewed
Aug 22, 2023
There was a problem hiding this comment.
@Djokovic0311 Just one comment about this, it should be an easy fix
Comment on lines
51
to
52
| private static final String[] posTypeList = {"true", "yes"}; | ||
| private static final String[] negTypeList = {"false", "no"}; |
There was a problem hiding this comment.
How about doing this, so we can avoid doing the conversion every time?
Suggested change
| private static final String[] posTypeList = {"true", "yes"}; | |
| private static final String[] negTypeList = {"false", "no"}; | |
| private static final List<String> posTypeList = Arrays.asList("true", "yes"); | |
| private static final List<String> negTypeList = Arrays.asList("false", "no"); |
|
Kudos, SonarCloud Quality Gate passed!
|
jagnathan
pushed a commit
to pughlab/cbioportal
that referenced
this pull request
Nov 8, 2023
* update possible valid binary types * Update ExpressionEnrichmentUtil.java * modify postypelist datatype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is an enhancement of previous one inspired by one recent data sample. #10303 Add other allowed values for generic assay binary data. Now it supports both "yes" and "true" for pos samples while "no" and "false" for neg samples.
Could you please have a look at this pr? @dippindots @fuzhaoyuan Any suggestions or modifications are welcome!