Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch off spring security on public VS endpoints #10893

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Switch off spring security on public VS endpoints #10893

merged 2 commits into from
Jul 17, 2024

Conversation

forus
Copy link
Contributor

@forus forus commented Jul 15, 2024

We are making this change to simplify publishing and unpublishing by using only our custom authorization token, without spring security tokens. The same way the /api/cache call does.

To publish a virtual study, you need to supply the publisher API key in the `X-PUBLISHER-API-KEY` header.
Here is a curl command to publish a virtual study:
```shell
curl \
-X POST \
-H 'X-PUBLISHER-API-KEY: <session.endpoint.publisher-api-key>' \
-v 'http://<cbioportal_host>/api/public_virtual_studies/<virtual_study_id>'
```

cBioPortal does not have an admin role atm. Having the token makes you an admin.

For publishing and un-publishing we use token base authorisation
@pieterlukasse
Copy link
Member

Looks good to me 👍
It follows the security pattern of /api/cache, so I understand we're not introducing a new pattern.

Copy link

sonarcloud bot commented Jul 17, 2024

@forus forus added the bug label Jul 17, 2024
@forus forus merged commit d8e6a1a into master Jul 17, 2024
19 of 21 checks passed
@forus forus deleted the rfc83 branch July 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants