Rfc80/clinical data counts refactor #11084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haynescd
force-pushed
the
rfc80/clinical-data-counts-refactor
branch
from
4eaaaf4
to
598e9fe
Compare
fuzhaoyuan
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Do you think if it's possible to change from using ClinicalDataBinner to BasicDataBinner?
From @dippindots it's usable. And then we can get rid of ClinicalDataBinner.
- This is meant for bin-counts endpoint, not this one.
onursumer
previously approved these changes
Oct 16, 2024
src/main/resources/org/cbioportal/persistence/mybatisclickhouse/StudyViewMapper.xml
Show resolved
Hide resolved
.../java/org/cbioportal/persistence/mybatisclickhouse/StudyViewMapperClinicalDataCountTest.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Clinical data counts to use SQL only