Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steam issues when recreating the client connection #242

Merged
merged 18 commits into from
Apr 15, 2024

Conversation

cBournhonesque
Copy link
Owner

@cBournhonesque cBournhonesque commented Apr 14, 2024

There are several issues with NetworkingConfigEntry:

Apart from that:

  • Steam works on 0.13.0

  • It is broken since the changes where we re-create the ClientConnection whenever we try to connect. (it still works if we create the steamworks::client only once during the program)

  • What I tried:

    • Dropping the existing ClientConnection (which calls steam api's shutdown) before re-creating the new one. Looks like this doesn't work because steams "shutdown" api pretty much does nothing; steam api is running until the program is shutdown: OnDestroy SteamAPI.Shutdown() is NOT working rlabrecque/Steamworks.NET#187 (comment))
    • tried initializing the steamworks clients only once via OnceCell, the client is able to connect, but is then disconnected immediately with reason: RemoteBadCert
    • If I connect immediately when creating the client, it works. It just doesn't work if I delay the connection by connecting only when I click on the 'connect' button. (even if I didn't delete the Client, but I just re-use the same one instead)
    • I tried adding a background system that just runs steam callbacks at all times even if we're not connected, but that didn't help either
    • in the file 'cef_log.previous, i See logs saying Error parsing cert retrieved from AIA (as DER). Couldn't read tbsCertificate as SEQUENCE. Failed parsing Certificate`
    • INTERESTING QUIRK: if I connect immediately when starting the client app, then I can disconnect/reconnect at will using the button!!! (meaning that everything works). The issue is that without that initial connection, I get a RemoteBadCert
    • If I connect immediately when starting the app, it works
    • If I don't connect immediately; on the first connection attempt I get disconnected with an error RemoteBadCert, but future connection attempts work!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.57%. Comparing base (64226bf) to head (eb6a06f).
Report is 2 commits behind head on main.

❗ Current head eb6a06f differs from pull request most recent head 56ec2c7. Consider uploading reports for the commit 56ec2c7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   61.56%   61.57%   +0.01%     
==========================================
  Files         144      144              
  Lines        9070     9070              
==========================================
+ Hits         5584     5585       +1     
+ Misses       3486     3485       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cBournhonesque cBournhonesque merged commit 0bb918c into main Apr 15, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Netcode C-Bug Something isn't working P-Critical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants