i18n all options menu #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbers) * Adds signatures to numericPref and checkboxPref that parse the preference Title and Description and pass them to the element in the Pane. Some text in the EditingPreferencesPane has been ported to the user-prefs-schema.json because it is more descriptive * Above signatures add tool tips to any option that has a description in the users-prefs-schema.json file. This adds tooltips to many options that previously did not have them. Most Titles/Descriptions are the same or very similar to the static strings that were in EditingPreferencesPane before, but some have slight changes. Need to check whether there's any material reversions that have occurred. Enumerators and statically defined headings are still todo
* Add human readable text corresponding to enumerators in user-prefs-schema.json. Add handling of these in generate-prefs.R to export human readable enumerators to translation files/use those translations instead of hard coded text in EditingPreferencesPane.java. * Add convenience signatures to SelectWidget * Convert EditingPreferencesPane.java's SelectWidget's to i18n * Remove CommandConstants.properties file that should have been removed previously * Minor updates to user-prefs-schema.json to reconcile differences with hard-coded strings in EditingPreferencesPane.java
skyeturriff
reviewed
Jul 6, 2021
skyeturriff
reviewed
Jul 6, 2021
src/gwt/src/org/rstudio/studio/client/workbench/prefs/views/LineEndingsSelectWidget.java
Show resolved
Hide resolved
skyeturriff
reviewed
Jul 6, 2021
|
|
||
| public class ChooseEncodingDialog extends ModalDialog<String> | ||
| { | ||
| // TODO: i18n |
There was a problem hiding this comment.
Is there still a TODO for this one?
skyeturriff
reviewed
Jul 6, 2021
src/gwt/src/org/rstudio/studio/client/workbench/prefs/views/EditingPreferencesPane.java
Show resolved
Hide resolved
|
Looks like quite a few are needing changes to |
|
I believe these dropdown vals can be i18n'd through |
|
A few more missing, these are hardcoded in |
|
Just missing on the Cancel button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes StatCan/aaw#513