develop #2
Draft
develop #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types are only used as atoms during map conversions
While not required from Sofa viewpoint as the keys are converted to/from strings during marshalling, this allows Ecto changesets to work transparently. They do not like mixed atoms & strings for keys.
- check that couchdb hashes plaintext passwords and strips out the password field before returning - ensure that `type: :user` field is present - check that PUTting new users handles multiple roles correctly
If a top-level key named "type": "Foo" is present, check to see if a corresponding atom named :"Elixir.Foo" is present in the existing atom table. This permits user functions to dispatch based on atom type in the returned doc struct, to an Ecto schema function directly, or similar custom user function as required. - upgrade from_map/1 and to_map/1 - add coerce_to_elixir_type/1 - add coerce_to_json_string/1 - remove struct related names from type fields - sprinkle a few tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the develop branch exists so I can force-push and not feel guilty