Support for Elixir 1.15 and OTP 26 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanazam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Elixir 1.15.2 and OTP 26.0.2.
It was originally opened on the original repo, but the owner does not seem to be reachable.
The main issue here is that
Port.comandis erroring out because of a behavior change on OTP that's not going to be updated.Related issue on Statix: lexmag#69
Related issue on top: erlang/otp#7130
In summary, Statix was using
Port.commandto avoid a performance issue with using:gen_udp.send.This approach no longer works because of OTP updates happening at the networking layer.
In order to avoid this, this PR uses
gen_udp.send(which has been optimized), but with this change, a lot of the existing code is no longer useful.Port.commandexpects a packet containing the IP and port of the destination to which the packet will be sent.This is no longer required with the new approach, but we need to keep the address and port on the
Connmodule to be able to do the:gen_udp.sendcalls to send Statds servers.This patch has been tested in production, see: knocklabs#1