DP-626 Request to join org migration #742
Conversation
| namespace CO.CDP.OrganisationInformation; | ||
|
|
||
| [JsonConverter(typeof(JsonStringEnumConverter))] | ||
| public enum JoinRequestStatus |
There was a problem hiding this comment.
Suggestion, can we rename to RequestStatus ?
There was a problem hiding this comment.
That seems too generic to me. Could mean any kind of request then in another developer's eyes and could be confusing. HttpRequest, for example, also has a status.
There was a problem hiding this comment.
@jakzal thoughts?
| namespace CO.CDP.OrganisationInformation.Persistence; | ||
|
|
||
| [Index(nameof(Guid), IsUnique = true)] | ||
| public class JoinRequest : IEntityDate |
There was a problem hiding this comment.
Suggestion, table name - OrganisationPersonAccessRequest ?
There was a problem hiding this comment.
I still prefer join request. Had a session with @jakzal and we thought it appropriate. See https://lucid.app/lucidspark/cb2c1600-0bff-42f2-b5d1-d3c96321b0ca/edit?invitationId=inv_3c51f859-f04a-4885-aff3-a3d949d11acd&page=0_0# for more info
There was a problem hiding this comment.
Naming it OrganisationJoinRequest wouldn't hurt while giving more context?
Services/CO.CDP.OrganisationInformation.Persistence/JoinRequest.cs
Outdated
Show resolved
Hide resolved
No description provided.