Fix filter by status #230
Merged
Fix filter by status #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In migration drop schedule status changed down to match table name * Removed some Todo's * Created ScheduleStatusFilter * Changed Schedule controller to be able to filter on status again * Added tests to check if status filters works * Altered the Schedule Model to make sure that if completed at is in the future is shows in progress * Altered the Schedule model to fix the scopes
It's for PHPStan
jbrooksuk
reviewed
Feb 8, 2025
This meets the requirements of Using the enum.
Although QueryBuilder might be a bit extreme for this
Altered the tests to add entities before doing the test so it can check if the ID retrieved is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when trying to filter by status with the API
The is an SQL error because the status field has been removed.
This pull request fixed that error.
Also made sure that if the completed_at is in the future that the status of the schedule is show as in_progress instead of completed
Show the planned maintenance correctly on the status-page
Altered all Show methods in the API controllers.
To retrieve the entity by id instead of getting the first record in the table