-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add devenv.flakeArgs
to avoid --no-pure-eval
#1418
base: main
Are you sure you want to change the base?
Conversation
@domenkozar What do you think? |
I like the idea of making devenv more pure but I would avoid putting necessary steps into the BTW. isn't |
This PR did not affect Since it changed
Yes |
@domenkozar Potentially |
We have some PHP tests that write session files to |
This PR avoids
--no-pure-eval
indevenv-devShell.nix
, in favor of"--override-input" "devenv-root" "path:.devenv/state/pwd"
.