Skip to content

Conversation

leiserfg
Copy link
Contributor

I replaced the explicit calls to pre-commit with getExe so there is a single if involved. I didn't update the readme and docs references to pre-commit 'cause I'm not sure how we wanna handle it.

@sandydoo sandydoo added the enhancement New feature or request label Oct 1, 2025
Copy link
Member

@sandydoo sandydoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

I'd like to merge this without changing the default to prek for now.
After a period of testing (perhaps in devenv), we can make the switch in a separate PR.

_module.args.pkgs = pkgs;
_module.args.gitignore-nix-src = gitignore-nix-src;
package = lib.mkDefault pre-commit;
package = lib.mkDefault (if builtins.hasAttr "prek" pkgs then pkgs.prek else pkgs.pre-commit);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
package = lib.mkDefault (if builtins.hasAttr "prek" pkgs then pkgs.prek else pkgs.pre-commit);
package = lib.mkDefault pre-commit;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants