This repository has been archived by the owner on Apr 14, 2019. It is now read-only.
Fix netfile download #260
Merged
Fix netfile download #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The column headers in data/netfile/csv/netfile_cal201_transaction.csv did not match the table schema, resulting in an import error. I updated the corresponding model to match.
|
I was just about to put in a request containing much of this :-( |
|
Oh, rough :( Sorry for the duplicate work |
|
👍 Looks good, is it possible to make it work better so that new fields from netfile don't break the import? The assertion message is great so we know exactly what to fix the next time it comes up. |
|
Yeah, I was thinking about that. We could output a warning message, but short of determining the table's schema dynamically (which seems pretty weird), I don't think we're going to be able to automatically do the right thing. Switch to MongoDB? |
|
Don't you need to set null=True. I got errors when I did not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column headers in data/netfile/csv/netfile_cal201_transaction.csv
did not match the table schema, resulting in an import error.
I updated the corresponding model to match.