WIP: Path to locality- & date-nested contributions data in committee.html #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEADS UP: This work depends on yet-to-be-merged backend changes.
This work resolves #435.
Updates committee.html to get the contributions data for the committee at the path
_data/committees/<locality>/<election-date>/<committee-id>.json, or in Jekyll-ish terms,site.data.committees[locality.slug][election_day][committee.filer_id].Adds Jekyll "where" queries to get locality and election date for committee from
site.localitiesandsite.elections. Is there a better way to do this, perhaps building that information right into the committee's markdown file?🤷 NOTE: The query to get election date depends on
committee.election, which is not a key that exists on the committee markdown file, and yet it seems to be working by some mystical interdimensional force. Maybe we should understanding how this is working before this gets merged.Previews
Large screens
Small screens