Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UBI image support #372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Victoremepunto
Copy link

based on the spirit of #5 and since I thought it may be really useful to have UBI based images for caddy.

@francislavoie
Copy link
Member

I think this needs a Dockerfile.ubi.tmpl similar to https://github.com/caddyserver/caddy-docker/blob/master/Dockerfile.tmpl so that the codegen produces the files correctly.

@Victoremepunto
Copy link
Author

I think this needs a Dockerfile.ubi.tmpl similar to https://github.com/caddyserver/caddy-docker/blob/master/Dockerfile.tmpl so that the codegen produces the files correctly.

Thanks @francislavoie , I just submitted it!

@Victoremepunto
Copy link
Author

@francislavoie ping! Hello , what is required for this to move forward ? do I need to do anything else ?

Also, would it be better to set it to UBI-8 instead (more stable) ?

I also saw #369 and thought it might be really helpful indeed, esp. for running in Openshift clusters, I can incorporate those changes in this PR as well.

@francislavoie
Copy link
Member

This is still incomplete, the make script doesn't produce the correct output. We would need to reorganize the folders to be like alpine, alpine-builder, ubi and ubi-builder, and make sure the correct templates are used for each. Right now make is using the alpine template for ubi which isn't correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants