Debug login problems #252
Open
Debug login problems #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +84,12 @@ | |||
| <appender-ref ref="main"/> | |||
| </category> | |||
|
|
|||
| <category name="br.com.caelum.vraptor.simplemail.aws"> | |||
| <category name="org.mamute.auth"> | |||
| <priority value="DEBUG"/> | |||
There was a problem hiding this comment.
should this be DEBUG by default?
There was a problem hiding this comment.
@cpfeiffer change here to info and debug
|
I like this change in general - I had some login issues myself due to connection problems to our LDAP server. |
| @@ -227,7 +228,7 @@ private void updateAvatarImage(LDAPResource ldap, Entry entry, User user) { | |||
| private void createUserIfNeeded(LDAPResource ldap, String cn) throws LdapException { | |||
| Entry ldapUser = ldap.getUser(cn); | |||
| String email = ldap.getAttribute(ldapUser, emailAttr); | |||
| User user = users.findByEmail(email); | |||
| User user = email != null ? users.findByEmail(email) : null; | |||
There was a problem hiding this comment.
Add some unit tests to this case that email is null
|
@cpfeiffer can you add the unit tests that I mentioned up there? |
|
Yes, sorry, I will eventually do it, I'm just too busy with other things at the moment. I had to debug login problems at work and needed to fnid out the actual ldap error cause, that's why I quickly updated the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.