Change how we make allFiles.json #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview site available at fix-readability.pr.digital.ca.gov. |
|
This is awesome @xjensen -- I'll transfer these ideas to the innovation hub, which was based on the former system, today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total change to the way we generate the
_site_dist/allFiles.jsonfile. This file is used for both readability scoring and tests.It turns out 11ty gives us this file, verbatim, for free. All we need to do is write out the
resultsfrom theeleventy.afterevent (docs).By using 11ty's method, we avoid iterating over each page and writing out the results ourselves. Our manual iterations led to some bugs that sometimes prevented all our pages from making their way into
allFiles.json. In turn, this is why some pages were missing their readability scores.With this change, we can also simplify the tests a bit, also included here.