-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11ty Config Cleanup #242
11ty Config Cleanup #242
Conversation
Preview site available at config-cleanup-1.pr.digital.ca.gov. |
Once this is done I'd like to apply it to hub.innovation.ca.gov and abortion.ca.gov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this first set of fixes doesn't apply to hub, nor abortion, because they aren't wordpress based. I do love the idea of using 11tydata.js files for page-specific 11ty code.
For some reason I keep forgetting that innovation has a WordPress backend. Denial? |
I've got two more big changes ready for consideration. First, the PAR scores have been integrated into 11ty's Data Cascade. We no longer need the Second, I've brought in 11ty's navigation plugin, which we can use to create the breadcrumbs a bit more easily. |
Very nice, I'll review this afternoon.
…On Tue, Jan 9, 2024 at 11:03 AM Jon Jensen ***@***.***> wrote:
I've got two more big changes ready for consideration.
First, the PAR scores have been integrated into 11ty's Data Cascade. We no
longer need the npm run readability script, the collection of Nunjucks
filters used to format PAR data, etc. This code has been relocated to
pages/_data/eleventyComputed.js.
Second, I've brought in 11ty's navigation plugin
<https://www.11ty.dev/docs/plugins/navigation/>, which we can use to
create the breadcrumbs a bit more easily.
—
Reply to this email directly, view it on GitHub
<#242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACGJ2N3LEBYSMA3S5KVC7TYNWIBBAVCNFSM6AAAAABBNGYGQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGYYTSNZVGQ>
.
You are receiving this because you commented.Message ID: <cagov/innovation
.***@***.***>
|
@xjensen I am currently getting a local build error on this branch (after running npm install; npm run dev) -- does not occur on main branch.
Also curious about the changes to the readability method. Previously if I wanted to test a readability run, I would run |
I got that error too, but never figured out why. It went away when I did a manual delete of the Yes, the readability scores run fresh on every build. We could probably re-do the |
Yeah, that fixes it. Approving... Merging... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reimplemented readabiity scores in a more efficient way.
Nvm, looks like this is still in draft mode... |
I'll have it ready soon. Not planning to make any more big changes. Just want to make sure the site still behaves as expected. |
@jbum I think this is ready for review. |
Looks good -- go ahead and merge :) |
This PR cleans up our management of content metadata. Nowadays 11ty offers many options, such as the full Data Cascade, to help process content. Let's use 'em.