Include Google Analytics code #451
Conversation
| @@ -75,6 +101,7 @@ export default function Home({ | |||
| href="https://fonts.googleapis.com/css2?family=Source+Sans+Pro:ital,wght@0,400;0,700;1,400;1,700&display=swap" | |||
| rel="stylesheet" | |||
| /> | |||
| {enableGoogleAnalytics === 'enabled' && googleAnalytics} | |||
There was a problem hiding this comment.
I think I might be being dense here. Doesn't this expression evaluate to true/false?
There was a problem hiding this comment.
It's a JSX feature, react conditional rendering: https://reactjs.org/docs/conditional-rendering.html#inline-if-with-logical--operator
There was a problem hiding this comment.
oh wow Javascript doesn't do this natively? TIL
| @@ -99,6 +126,9 @@ export const getServerSideProps: GetServerSideProps = async ({ req, res, locale, | |||
| urlPrefixBpo: process.env.URL_PREFIX_BPO ?? '', | |||
| } | |||
|
|
|||
| // Set to 'enabled' to include Google Analytics code | |||
| const ENABLE_GOOGLE_ANALYTICS = process.env.ENABLE_GOOGLE_ANALYTICS ?? '' | |||
There was a problem hiding this comment.
Do we need to be alerted on whether this env var is missing? If so, there is code in queryApiGateway.ts that could be re-used or generalized.
There was a problem hiding this comment.
Oh interesting! I guess ideally we could be alerted if it's missing in production, and only in production. I don't think we currently have a way of detecting whether we're in production (although it's easy enough to add an env var for that), so I'll create a ticket to alert if it's missing in prod, how's that sound?
There was a problem hiding this comment.
I don't think we currently have a way of detecting whether we're in production
We do! We're doing that for the missing unique number.
There was a problem hiding this comment.
(talked to Rocket, we don't have a way in our codebase of detecting whether we're in prod)
created: #460
| gtag('config', 'UA-3419582-2', { 'anonymize_ip': true }) // www.ca.gov | ||
| gtag('config', 'UA-3419582-31', { 'anonymize_ip': true }) // edd.ca.gov` | ||
|
|
||
| const googleAnalytics = ( | ||
| <> | ||
| {/* Global site tag (gtag.js) - Google Analytics */} | ||
| <script async src="https://www.googletagmanager.com/gtag/js?id=UA-3419582-2" /> |
There was a problem hiding this comment.
I feel like there's a teeny bit of a bad code smell here with the hardcoded IDs.
There was a problem hiding this comment.
Hmm. Is there a constants file I could move this to? It doesn't make sense for it to be an env var.
This PR adds the Google Analytics code snippet. It also creates a new environment variable, ENABLE_GOOGLE_ANALYTICS, that must be set to 'enabled' for the GA snippet to render.
===
Resolves #313
main