Full test for app #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice to see if this app started once a week or so Signed-off-by: JJ Asghar <[email protected]>
Lets run this on wednesday at midnight Signed-off-by: JJ Asghar <[email protected]>
jjasghar
requested review from
markstur,
bridgetmcg,
alanbraz,
hickeyma,
gkumbhat,
gabe-l-hart,
joerunde,
prashantgupta24,
evaline-ju,
alex-jw-brooks and
tharapalanivel
as code owners
|
python: can't open file 'app.py': [Errno 2] No such file or directory |
|
yep, i'll poke around asap. |
`app.py` is in a subdirectory Signed-off-by: JJ Asghar <[email protected]>
gabe-l-hart
reviewed
Apr 11, 2024
| - name: Start the application | ||
| working-directory: ./caikit-huggingface-demo | ||
| run: | | ||
| python app.py & |
There was a problem hiding this comment.
Do we need to kill the backgrounded task, or will GHA automatically do that since it's in the background?
There was a problem hiding this comment.
I'm 95% it'll be killed as soon as the tests pass. I'll see if I can find documentation to back this claim up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets make sure the app starts up at least once a week.
/cc @markstur