Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Cake.Core Dependency to 2.0.0+ #106

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ericburcham
Copy link

@ericburcham ericburcham commented May 26, 2022

Description

During my usage of this Cake plugin, I noticed the following warning message:
The assembly 'Cake.DocFx, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null'
is referencing an older version of Cake.Core (1.0.0).
For best compatibility it should target Cake.Core version 2.0.0.

I decided to see if I couldn't fork your repo and add support for Cake.Sure 2.0.0.

I was able to update the dependencies, and the projects compile fine in Visual Studio. But the Cake Build recipe is now broken. I had to update the solution projects to net5.0 in order to adopt Cake.Core 2+, and it looks like the Cake dependencies in the plugin's build script only support netcoreapp. I do not have time to take the work further without instruction, but if you can provide guidance to solve those problems, I'll spend some more time and see what I can do.

Related Issue

Latest Cake Build emits warning: The assembly 'Cake.DocFx, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' is referencing an older version of Cake.Core (1.0.0). For best compatibility it should target Cake.Core version 2.0.0.

Motivation and Context

I'm mostly trying to be helpful.

How Has This Been Tested?

See the description.

Types of changes

  • [x ] Breaking change - If following semantic versions, this would require a new major version, as the TargetFramework had to be updated.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. - I'm happy to do so with some guidance.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant