Skip to content

Commit

Permalink
(GH-44) Enable SourceLink with embedded pdb
Browse files Browse the repository at this point in the history
  • Loading branch information
gep13 committed Jul 2, 2020
1 parent 4c9812f commit fd8fd78
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/Cake.Json/Cake.Json.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,16 @@
<PackageProjectUrl>https://github.com/redth/Cake.Json</PackageProjectUrl>
<PackageIconUrl>https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png</PackageIconUrl>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Cake.Core" Version="0.35.0" PrivateAssets="All" />
<PackageReference Include="Cake.Common" Version="0.35.0" PrivateAssets="All" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
</ItemGroup>

</Project>

3 comments on commit fd8fd78

@gitfool
Copy link
Contributor

@gitfool gitfool commented on fd8fd78 Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gep13 LGTM. Have you managed to step debug into it?

image

@gep13
Copy link
Member Author

@gep13 gep13 commented on fd8fd78 Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on my list to verify today 😄

@gep13
Copy link
Member Author

@gep13 gep13 commented on fd8fd78 Jul 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitfool ITS ALIVE...

image

There actually isn't much to debug into for this alias, as it is a very thinner wrapper over NewtonSoft, but it works! 😄

Please sign in to comment.