Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cake.Issues #376

Conversation

pascalberger
Copy link
Member

Update Cake.Issues to 0.7.x which is build against Cake 0.33.0

@Jericho
Copy link
Member

Jericho commented Jul 16, 2019

FYI: this will be taken care of automatically by the AddinDiscoverer. When all addins referenced by Cake.Recipe support Cake 0.33.0 the automated tool will submit a PR to upgrade all addins at once and also update the version of Cake used to build Cake.Recipe.

The progress is monitored in #313. As of this writing, two addins are preventing upgrading to 0.33.0: Cake.Graph and Cake.AppVeyor.

@AdmiringWorm
Copy link
Member

@Jericho Cake.Graph have already been updated to Cake 0.33.0, so something seems to be wrong here.

It even say so in the Audit docs as well: https://github.com/cake-contrib/Home/blob/master/Audit_for_Cake_0.33.0.md

@Jericho
Copy link
Member

Jericho commented Jul 16, 2019

@AdmiringWorm thanks for pointing this out. I’ll investigate.

@Jericho
Copy link
Member

Jericho commented Jul 17, 2019

@AdmiringWorm the latest version of Cake.Graph nuget package is considered to be prerelease and the AddinDiscoverer specifically excludes prerelease packages as far as updating the references in Cake.Recipe is concerned. Prerelease packages are not excluded in the markdown report you previously linked.

The reason why this nuget package was flagged as prerelease is because it's depending on RazorLight 2.0.0-beta1 which itself is prerelease.

This explains why the addin is indicated as supporting Cake 0.33.0 in the markdown and Excel reports but it is not considered as supporting Cake 0.33.0 as far as updating Cake.Recipe is considered.

@Jericho
Copy link
Member

Jericho commented Jul 17, 2019

On a separate but related note: this is not the first time that prerelease package have caused headaches. I've had several discussions with various people on Gitter and it has come up here, here and here

I also raised an issue a little while ago where I started a discussion about what the AddinDiscoverer should do with prerelease packages. I welcome ideas and feedback.

@Jericho
Copy link
Member

Jericho commented Jul 22, 2019

FYI: new version of AddinDiscoverer has been released and Cake.Graph is now properly considered as "compatible with Cake 0.33.0".

Cake.AppVeyor is now the only addin preventing Cake.Recipe from upgrading to Cake 0.33.0

@gep13
Copy link
Member

gep13 commented Sep 13, 2019

This has been rebased and merged here: 145432b

@gep13 gep13 added the Build label Sep 13, 2019
@gep13 gep13 added this to the 2.0.0 milestone Sep 13, 2019
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 closed this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants