-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cake.Issues #376
Update Cake.Issues #376
Conversation
FYI: this will be taken care of automatically by the AddinDiscoverer. When all addins referenced by Cake.Recipe support Cake 0.33.0 the automated tool will submit a PR to upgrade all addins at once and also update the version of Cake used to build Cake.Recipe. The progress is monitored in #313. As of this writing, two addins are preventing upgrading to 0.33.0: Cake.Graph and Cake.AppVeyor. |
@Jericho Cake.Graph have already been updated to Cake It even say so in the Audit docs as well: https://github.com/cake-contrib/Home/blob/master/Audit_for_Cake_0.33.0.md |
@AdmiringWorm thanks for pointing this out. I’ll investigate. |
@AdmiringWorm the latest version of Cake.Graph nuget package is considered to be The reason why this nuget package was flagged as This explains why the addin is indicated as supporting Cake 0.33.0 in the markdown and Excel reports but it is not considered as supporting Cake 0.33.0 as far as updating Cake.Recipe is considered. |
On a separate but related note: this is not the first time that I also raised an issue a little while ago where I started a discussion about what the AddinDiscoverer should do with prerelease packages. I welcome ideas and feedback. |
FYI: new version of AddinDiscoverer has been released and Cake.Graph is now properly considered as "compatible with Cake 0.33.0". Cake.AppVeyor is now the only addin preventing Cake.Recipe from upgrading to Cake 0.33.0 |
This has been rebased and merged here: 145432b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update Cake.Issues to 0.7.x which is build against Cake 0.33.0