Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT vs Schedule #1033

Merged
merged 9 commits into from
Feb 20, 2024
Merged

RT vs Schedule #1033

merged 9 commits into from
Feb 20, 2024

Conversation

amandaha8
Copy link
Contributor

  • Added in schedule gtfs key route_id dir_id time_of_day and offpeak_onpeak columns to routes and trips.
  • Separated workstream between routes and trips. Metrics are always generated on a trip level. Routes is calculated with a weighted average and any metrics from trip are deleted before added back in.
  • Saved outputs to the correct folder in GCS's rt_v_schedule folders.
  • New function that adds in time_of_day in segment_speed_utils based on vp positions instead of schedule. If the trip is only found in vp_usable and not in both vp_usable and schedule, we can determine now the time_of_day based on vp.

@amandaha8 amandaha8 merged commit 9c6c623 into main Feb 20, 2024
3 checks passed
@amandaha8 amandaha8 deleted the route_agg branch February 20, 2024 18:16
Copy link

"vp_in_shape",
]

count_cols = ["trip_instance_key"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiffanychu90 Can you tell me if I added too many columns in the group_cols list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just need group_cols = ["schedule_gtfs_dataset_key", "route_id", "direction_id"].
I think peak_offpeak and time_of_day are going to force the granularity to be more fine than we want. It'll leave rows like route A - direction 0- AM_peak - peak, route A-direction 0 - Midday-offpeak. which is too granular. We want route A - direction 0 - peak, route A - direction 0 - offpeak, route A - direction 0 - all_day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants