-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RT vs Schedule #1033
RT vs Schedule #1033
Conversation
nbviewer URLs for impacted notebooks: |
"vp_in_shape", | ||
] | ||
|
||
count_cols = ["trip_instance_key"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tiffanychu90 Can you tell me if I added too many columns in the group_cols list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just need group_cols = ["schedule_gtfs_dataset_key", "route_id", "direction_id"]
.
I think peak_offpeak
and time_of_day
are going to force the granularity to be more fine than we want. It'll leave rows like route A - direction 0- AM_peak - peak
, route A-direction 0 - Midday-offpeak
. which is too granular. We want route A - direction 0 - peak
, route A - direction 0 - offpeak
, route A - direction 0 - all_day
schedule gtfs key
route_id
dir_id
time_of_day
andoffpeak_onpeak
columns toroutes
andtrips
.routes
andtrips
. Metrics are always generated on atrip
level.Routes
is calculated with a weighted average and any metrics fromtrip
are deleted before added back in.rt_v_schedule
folders.time_of_day
insegment_speed_utils
based onvp
positions instead ofschedule
. If the trip is only found invp_usable
and not in bothvp_usable
andschedule
, we can determine now thetime_of_day
based onvp
.